test: reject hyphenated UDF argument names - #24751
Open
mattisonchao wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24751 +/- ##
==========================================
- Coverage 81.47% 81.47% -0.01%
==========================================
Files 1122 1122
Lines 404140 404140
Branches 404140 404140
==========================================
- Hits 329284 329273 -11
- Misses 55546 55553 +7
- Partials 19310 19314 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jefffrey
approved these changes
Aug 28, 2026
Jefffrey
left a comment
Contributor
There was a problem hiding this comment.
can you show an example of this test failing, just to see what the output looks like
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
UDF argument names are copied into generated function documentation. Hyphenated names make the documentation inconsistent with the underscore style used by SQL syntax, and the repository currently has no automated check preventing them from being reintroduced.
What changes are included in this PR?
Adds a function-documentation test that scans the scalar, higher-order, aggregate, and window UDF registries and reports any hyphenated argument name, directing contributors to use underscores. The existing SQL table-format test now shares the same registry traversal helper.
Are these changes tested?
Yes.
Are there any user-facing changes?
No. This validates repository-owned generated documentation metadata and does not change SQL behavior or public APIs.