refactor(compiler): emit any as type argument for ɵɵInjectableDeclara… - #70401
Open
atscott wants to merge 1 commit into
Open
refactor(compiler): emit any as type argument for ɵɵInjectableDeclara…#70401atscott wants to merge 1 commit into
atscott wants to merge 1 commit into
Conversation
atscott
force-pushed
the
fix-injectable-declaration-any-type
branch
from
August 26, 2026 16:47
c0cbec6 to
fcc15ce
Compare
atscott
marked this pull request as ready for review
August 26, 2026 16:48
crisbeto
approved these changes
Aug 26, 2026
atscott
force-pushed
the
fix-injectable-declaration-any-type
branch
from
August 26, 2026 18:30
fcc15ce to
24c4dd9
Compare
…tion The static `ɵprov` field emitted on `@Injectable()` classes uses `ɵɵInjectableDeclaration<T>`. When a subclass extends a generic `@Injectable()` base class with contravariant parameters (such as callback/transformer methods depending on generic type parameters), TypeScript's static side inheritance check (`typeof Sub extends typeof Super`) fails with `TS2417` because `ɵɵInjectableDeclaration<Sub>` is not assignable to `ɵɵInjectableDeclaration<Super<any>>`. Using `any` (`o.DYNAMIC_TYPE`) in `createInjectableType` avoids strict variance checks on static inheritance for internal Ivy definitions and aligns with other Ivy declaration types.
atscott
force-pushed
the
fix-injectable-declaration-any-type
branch
from
August 26, 2026 21:54
24c4dd9 to
4087b5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion
The static
ɵprovfield emitted on@Injectable()classes usesɵɵInjectableDeclaration<T>. When a subclass extends a generic@Injectable()base class with contravariant parameters (such as callback/transformer methods depending on generic type parameters), TypeScript's static side inheritance check (typeof Sub extends typeof Super) fails withTS2417becauseɵɵInjectableDeclaration<Sub>is not assignable toɵɵInjectableDeclaration<Super<any>>.Using
any(o.DYNAMIC_TYPE) increateInjectableTypeavoids strict variance checks on static inheritance for internal Ivy definitions and aligns with other Ivy declaration types.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information