fix: add large file support defines to fileio.c and persistence.c - #2947
Open
sithglan wants to merge 1 commit into
Open
fix: add large file support defines to fileio.c and persistence.c#2947sithglan wants to merge 1 commit into
sithglan wants to merge 1 commit into
Conversation
Owner
|
Thanks for the PR. Could you please rebase this on the latest master and push again? |
Without _FILE_OFFSET_BITS=64 and related LFS defines, fopen() and stat() fail with EOVERFLOW on 32-bit systems when opening log files larger than 2GB. Every other source file in the project already defines these macros.
Author
|
I rebased on master and pushed again.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without _FILE_OFFSET_BITS=64 and related LFS defines, fopen() and stat() fail with EOVERFLOW on 32-bit systems when opening log files larger than 2GB. Every other source file in the project already defines these macros.
The issue we had on 32 bit Debian Trixie:
Unable to open the specified log file '/var/log/nginx/access.log.1'. Value too large for defined data type