[JSC] TypedArray setFromTypedArray cannot use memmove when region is intentionally overlapping and spec algorithm read back the modified result - #72765
Conversation
β¦intentionally overlapping and spec algorithm read back the modified result https://bugs.webkit.org/show_bug.cgi?id=322892 rdar://186145219 Reviewed by NOBODY (OOPS!). TypedArray setFromTypedArray cannot use memmove when 1. region is overlapping 2. we end up reading the written result memmove can avoid (2) by changing the scanning direction. But the spec algorithm sometimes explicitly requests CopyType::LeftToRight, and in this case, this reading the written value should be observable. Test: JSTests/stress/typed-array-slice-species-same-buffer-overlap.js * JSTests/stress/typed-array-slice-species-same-buffer-overlap.js: Added. (shouldBe): (fill): (bytesOf): (const.TA.of.constructors.resultIndex.elementCount.ta.Symbol.species): (const.TA.of.constructors.resultIndex.elementCount): (const.TA.of.constructors.targetIndex.elementCount): * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h: (JSC::JSGenericTypedArrayView<Adaptor>::setFromTypedArray):
Collaborator
|
EWS run on current version of this PR (hash 1c95fcd) Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π ios-safer-cpp
1c95fcd
1c95fcd