Sequenceanim decode refactor - #1255
Draft
kristiker wants to merge 1 commit into
Draft
Conversation
kristiker
force-pushed
the
lazy-animation-resource
branch
from
August 7, 2026 23:34
68821b7 to
ba27559
Compare
kristiker
marked this pull request as draft
August 11, 2026 10:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazy, skeleton-invariant animation decoding
Segment decoders were built eagerly at model load with the target skeleton's bone indices baked in.
Now we defer the build on first playback/DecodeFrame. This also lets us play an Animation resource on various models without going through the GetEmbeddedAnimationsWithSkeleton hack.
Model.GetEmbeddedAnimationsWithSkeletonand its cachedSkeleton swap deleted; the animation factories and LoadAnimationGroup no longer take Skeleton/FlexController[].Two latent bugs gone: GetEmbeddedAnimationsWithSkeleton swapped cachedSkeleton then called GetAllAnimations, which short-circuits on CachedAnimations — so by load order it either ignored the swap or permanently cached another model's skeleton bindings.