Stop pinning the iPhone 16 simulator in the Makefile - #1916
Open
martinpucik wants to merge 1 commit into
Open
Conversation
All four targets named `iPhone 16` in their destination. That model is not installed on every machine, and the GitHub runner images do not always ship it either, so the build failed with "Unable to find a device matching the provided destination specifier". A run of the example job failed this way on a runner that had no simulator devices at all. Split the destination by what each target actually needs. Building needs a platform, not a booted device, so `framework` and `build_example` now ask for `generic/platform=iOS Simulator`. Neither depends on any device being installed. Running tests does need a real simulator, so `test` and `test_example` resolve whichever iPhone is installed and address it by identifier. `SIMULATOR_ID` can be overridden to choose a specific device. A `require_simulator` prerequisite reports a readable message when nothing resolves, instead of letting xcodebuild fail later with its own wording. Dropping `-sdk iphonesimulator` from `test` as well; the destination already selects the simulator SDK.
Kaspik
approved these changes
Aug 29, 2026
Kaspik
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All four
maketargets pinned-destination "platform=iOS Simulator,name=iPhone 16". That model is not installed everywhere, and the GitHub runner images do not always ship it, so the build fails with:This is what failed the example job on #1915. That runner had no simulator devices at all — only
Any iOS Simulator Deviceplaceholders. A re-run on a healthy runner passed with no code change.The fix splits the destination by what each target needs
Building needs a platform, not a booted device.
frameworkandbuild_examplenow usegeneric/platform=iOS Simulator, so they do not depend on any device being installed — which is exactly the case that failed.Running tests does need a real simulator.
testandtest_exampleresolve whichever iPhone is installed and address it by identifier:Override with
make test SIMULATOR_ID=<udid>to pick a specific device.A
require_simulatorprerequisite prints a readable message when nothing resolves, rather than letting xcodebuild fail later with its own wording.Also dropped
-sdk iphonesimulatorfromtest, since the destination already selects the simulator SDK.Verification
My machine has iPhone 17 and no iPhone 16, so it reproduces the CI condition. The old destination fails here with the identical error. With the change, all four targets pass:
frameworkgeneric/platform=iOS Simulator** BUILD SUCCEEDED **build_examplegeneric/platform=iOS Simulator** ANALYZE SUCCEEDED **testid=<resolved udid>** TEST SUCCEEDED **test_exampleid=<resolved udid>** TEST SUCCEEDED **The guard was checked too —
make test SIMULATOR_ID=prints the message and exits 1.I ran the underlying
xcodebuildcommands directly rather than throughmake, becausexcprettyis not installed on this machine. The runner images ship it, and this change does not touch that part of the recipes.Note
This branches from
mainwhile the doc and cleanup stack is still open. Both add entries to the CHANGELOG "Future release" section, so expect a small textual conflict there depending on merge order.