ifcviewer: support linking system-packaged wgpu-native and zstd - #9335
Open
brunopostle wants to merge 1 commit into
Open
ifcviewer: support linking system-packaged wgpu-native and zstd#9335brunopostle wants to merge 1 commit into
brunopostle wants to merge 1 commit into
Conversation
Add a WGPU_NATIVE_USE_SYSTEM option that resolves wgpu-native via pkg-config instead of FetchContent-ing upstream's prebuilt binary release, for distros (e.g. Fedora) that ship it as a system package. Also fall back to pkg-config for zstd when the CONFIG package isn't available, and skip the wgpu-native runtime install step when the system package already owns it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WGPU_NATIVE_USE_SYSTEMCMake option that resolveswgpu-nativevia pkg-config instead of FetchContent-ing upstream's prebuilt binary release, for distros (e.g. Fedora) that package it themselveszstdwhen the CMakezstdCONFIG package isn't availableWGPU_NATIVE_USE_SYSTEMis on, since the system package already owns the shared libraryTest plan
-DWGPU_NATIVE_USE_SYSTEM=ONon a system with awgpu-nativepkg-config file (e.g. Fedora) and confirm it links against the system package instead of fetching upstream's binary