Ignore only well known and minor jemalloc errors and add entry about disabled per-cpu arena into system.warnings - #116899
Ignore only well known and minor jemalloc errors and add entry about disabled per-cpu arena into system.warnings#116899azat wants to merge 2 commits into
Conversation
Previusly any message will be ignored, i.e. "Unsupported system page size", and all you see is crash.
|
Workflow [PR], commit [1900639] AI ReviewSummaryThis PR stops swallowing unexpected PR Metadata
Final Verdict
|
e1f7527 to
72dcbfc
Compare
| #if USE_JEMALLOC | ||
| { | ||
| /// "disabled" is also the jemalloc default, so only warn when the build-time configuration | ||
| /// requested per-CPU arenas (jemalloc overwrites the option value when it disables them at runtime). | ||
| const char * effective_mode = nullptr; | ||
| const char * compiled_conf = nullptr; | ||
| if (Jemalloc::tryGetValue("opt.percpu_arena", effective_mode) && effective_mode == std::string_view("disabled") | ||
| && Jemalloc::tryGetValue("config.malloc_conf", compiled_conf) && std::string_view(compiled_conf).contains("percpu_arena:percpu")) | ||
| { | ||
| server.context()->addOrUpdateWarningMessage( | ||
| Context::WarningType::JEMALLOC_PERCPU_ARENA_DISABLED, | ||
| PreformattedMessage::create("Per-CPU arenas were requested (`percpu_arena:percpu`), but jemalloc disabled them at startup")); | ||
| } | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Don't want to add integration test for this, but I've checked manually with taskset -c0, and the warning works
72dcbfc to
6606782
Compare
Build profile diff (arm_release)Comparing ✅ No significant changes. Binary sizes
Only the stripped binary is compared: the official master build keeps debug symbols while PR builds strip them, so the other binaries differ by construction. Compile time of recompiled translation units1265 translation units recompiled, 7587 s compile time in total, 1264 of them have a recent master baseline. |
6606782 to
5dfaffa
Compare
5dfaffa to
1900639
Compare
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Ignore only well known and minor jemalloc errors and add entry about disabled per-cpu arena into system.warnings
Workflow [PR]
Sync PR [sync-upstream/pr/116899]