fix: detect scheduled script navigations - #2622
Open
Elioooon wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
@Elioooon could you please sign the CLA? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Page.frameScheduledNavigationin addition toPage.frameStartedNavigatingwhile waiting for tool-triggered navigationsevaluate_scriptdoes not miss script-initiated navigations on slower platformsFixes #2609
Validation
npm run formatnpm run check-formatnpm run test tests/tools/script.test.tsnpm run test tests/utils/WaitForHelper.test.tsnpm run testwas also run. It failed in unrelated local environment/browser cases:browser_take_screenshot > with full page resulting in a large screenshot:Protocol error (Page.captureScreenshot): Page is too largeRisk
This only changes the early navigation-detection signal used by
WaitForHelper. It does not change navigation timeout values, stable DOM waiting, dialog handling, iframe filtering, or the finalnavigatedToUrlresponse construction.--browserUrland browser launch behavior are untouched.