Add cluster and per-database metrics toggles to collector components - #139
Open
paweljw wants to merge 1 commit into
Open
Add cluster and per-database metrics toggles to collector components#139paweljw wants to merge 1 commit into
paweljw wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collectors API now exposes finer-grained metrics component toggles. This models them in the
logtail_collectorresource and data source:metrics_cluster— canonical name for the cluster agent toggle. The API treats the existingmetrics_databasesas a legacy alias for the same setting and givesmetrics_clusterprecedence when both are sent;metrics_databasesis marked deprecated here accordingly.metrics_postgres,metrics_mysql,metrics_elasticsearch,metrics_pgbouncer— independent per-database Prometheus exporter toggles, enabled by default server-side.Unknown keys were previously dropped from the PATCH payload, so modeling them also makes the provider preserve these settings on configuration updates.
Docs regenerated with
make gen; the collector example demonstrates the new fields. Mock-server unit tests cover the round trip of the new keys and the deprecated alias.make testpasses.