Derive the connection data source schema from the resource - #131
Closed
prochac wants to merge 0 commit into
Closed
Conversation
prochac
force-pushed
the
refactor/connection-schema-derivation
branch
from
August 17, 2026 11:14
cf2707c to
39b3494
Compare
paweljw
force-pushed
the
refactor/connection-schema-derivation
branch
from
August 18, 2026 08:55
39b3494 to
8926247
Compare
Member
|
merged externally - it made it's way onto main. thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#130 fixes the panic from #129 at the point where it blows up. This PR removes the
condition that made it possible.
The data source hand-maintained a second copy of the resource's schema and the two
had drifted. That drift is what let the shared copier reach for
passwordon aschema that never declared it. The data source now derives its schema from
connectionSchema,passwordis named once inconnectionLookupOmits, and a testpins that the copier and the schema agree, so the next attribute added to the
resource can't silently go missing from the data source.
With value preservation in one place, this also fixes a second bug: the API returns
data_regionandvalid_untilnormalized, and adata_regioneven when none wasconfigured. Both are
ForceNewand neither isComputed, so any API value writtento state recreates the connection on every apply. The configured values are now
always kept, not just when set.
passwordis unchanged in effect; only createreturns it.
π€ Generated with Claude Code